Your team is doing feature branching and pull requests, but the code quality is still subpar? What many people don’t know: The code reviewers are simply approving with LGTM without a closer look due to time pressure. Therefore what you need is a code reviewer review. It works like this:
Step 1: The code reviewer reviewer looks over the code reviewer’s shoulder to make sure the code reviewer actually reviews the code.
Step 2: The code reviewer reviewer approves the code reviewer’s code review, or requests changes by commenting DLGTMT (short for “doesn’t look good to me though”).
Note that unless you are the code reviewer reviewer, you also need a code reviewer reviewer reviewer, because the code reviewer reviewer can’t be trusted to actually review the code reviewer’s code review.
This is a best practice because there are no alternatives to feature branching and pull requests.
(Happy April Fools day!)
Raimund Krämer 